Add object and args unwrapping function - #47
Conversation
|
Note to other reviewers; key change is here: - self.js_ref.exec(*args)
+ self.js_ref.exec(*dry.class_manager.unwrap_args(args))Because we had the special "_exec" method, it didn't go through the typical unwrap code it like it should have. Sidenote: CI integration tests for job deployal from bifrost2 would be extremely valuable to make sure changes like this don't cause any surprises Looks good to me |
yeah, those would be great. Unfortunately the two options are to use localexec (which only works in node so.... can't use this one) or to have a keystore with DCCs in it that the CI pipeline can access. Unfortunately I've never used github CI before, so don't know how to create secure pipelines where people can't exfiltrate secrets. Probably not too hard, but a matter of dedicating the time to read up on how. |
|
LGTM. Not sure who the official release manager is for bifrost nowadays, is it me, @Xmader or @JosephAcernese? |
|
I researched it a while ago. iirc to run a pipeline with secrets you can add secrets to the repository and use them in the pipeline. The only caveat is that you need to make it so pipelines can only be run by contributors, so people can't create & run pipelines which extract the secrets |
I thought you could deploy a job to no compute groups for free, then have a worker pick it up by jobid? I think I had done that in the past; I do recall that there was a bug preventing the ability to deploy using a wallet with no DCCs in it, but you can get around it by transferring some small amount of DCCs into it (for ex. the minimum dcc amount). |
This MR adds a class_manager method to unwrap proxy objects.
This partially resolves issue 46, but will likely need to be implemented in other parts of the API